Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency for setuptools, which is required by cli get_version command #168

Closed
wants to merge 1 commit into from
Closed

Add dependency for setuptools, which is required by cli get_version command #168

wants to merge 1 commit into from

Conversation

white-gecko
Copy link
Contributor

When I install warcio with pipx pkg_resources from setuptools is missing in the venv.

$ pipx install warcio                                                      
  installed package warcio 1.7.4, installed using Python 3.12.4
  These apps are now globally available
    - warcio
done! ✨ 🌟 ✨

$ warcio --version                                                         
Traceback (most recent call last):
  File "…/.local/bin/warcio", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "…/.local/share/pipx/venvs/warcio/lib64/python3.12/site-packages/warcio/cli.py", line 16, in main
    parser.add_argument('-V', '--version', action='version', version=get_version())
                                                                     ^^^^^^^^^^^^^
  File "…/.local/share/pipx/venvs/warcio/lib64/python3.12/site-packages/warcio/cli.py", line 60, in get_version
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

$ pipx uninstall warcio
uninstalled warcio! ✨ 🌟 ✨

$ pipx install git+https://github.com/white-gecko/warcio.git@feature/fixSetup
  installed package warcio 1.7.4, installed using Python 3.12.4
  These apps are now globally available
    - warcio
done! ✨ 🌟 ✨

$ warcio --version                                                           
warcio 1.7.4

@wumpus
Copy link
Collaborator

wumpus commented Aug 13, 2024

This is a quirk of a deprecation in Python 3.12, if I recall correctly.

@wumpus wumpus requested review from tw4l and wumpus August 13, 2024 19:26
@white-gecko
Copy link
Contributor Author

This would be obsolte with #169 anyhow.

@white-gecko
Copy link
Contributor Author

Since #168 is split into smaller portions. This pull request would not be obsolete anymore.

This was referenced Aug 19, 2024
Merged
Draft
@wumpus
Copy link
Collaborator

wumpus commented Aug 23, 2024

This was fixed in your other PRs. Thank you.

@wumpus wumpus closed this Aug 23, 2024
@white-gecko
Copy link
Contributor Author

Yes, you are right this is superseded by #173

@white-gecko white-gecko deleted the feature/fixSetup branch August 23, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wumpus wumpus wumpus approved these changes

@tw4l tw4l Awaiting requested review from tw4l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@white-gecko @wumpus